Skip to content

feat: support Node.js 26#578

Open
styfle wants to merge 8 commits into
mainfrom
styfle-ai/node-26-support-5409
Open

feat: support Node.js 26#578
styfle wants to merge 8 commits into
mainfrom
styfle-ai/node-26-support-5409

Conversation

@styfle
Copy link
Copy Markdown
Member

@styfle styfle commented May 12, 2026

Summary

  • Add Node.js 26 to the CI test matrix
  • Update npm package manager metadata and Node typings
  • Bump Node 26-sensitive integration dependencies and refresh affected fixtures
  • Skip Node 26-incompatible Datadog/PhantomJS fixtures via skipOnNode26AndAbove
  • Keep phantomjs-prebuilt as a real devDependency and fixture for Node 20/22/24 coverage
  • Use a Node script in CI to remove phantomjs-prebuilt from the Node 26 install manifest, since the PhantomJS fixture is skipped on Node 26 and its unsupported installer blocks Windows/macOS installs

Coverage comparison

  • With phantomjs-prebuilt: lines 91.03%, functions 96.36%, branches 88.31%
  • After removing phantomjs-prebuilt: tests pass, but functions drop to 95.75%
  • Kept the fixture because it covers a unique source path

Testing

  • npx npm@11.14.1 install
  • npx npm@11.14.1 run build
  • npx npm@11.14.1 run prettier-check
  • npx jest --verbose test/unit.test.js -t "phantomjs-prebuilt|datadog-pprof-node-gyp"
  • npx -y -p node@20 -c 'node -v && node node_modules/typescript/bin/tsc --sourceMap && node node_modules/jest/bin/jest.js --verbose test/unit.test.js -t "phantomjs-prebuilt|module-sync-condition-es-node20|module-sync-condition-cjs-node20"'
  • npx npm@11.14.1 run test-verbose
  • npx -y -p node@26 -c 'node node_modules/typescript/bin/tsc --sourceMap && node node_modules/jest/bin/jest.js --verbose --coverage --globals "{\"coverage\":true}"'
Open in Web Open in Cursor 

cursoragent and others added 3 commits May 12, 2026 19:25
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
@styfle styfle changed the title feat: support Node.js 26 feat: support Node.js 26, drop 20 May 12, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 12, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​twilio@​5.5.2 ⏵ 6.0.266 -33100100 +197 +3100
Updatednpm/​auth0@​3.7.2 ⏵ 5.9.174 -22100100100 +1100
Updatednpm/​@​types/​node@​14.18.63 ⏵ 25.7.010010081 +196100
Updatednpm/​axios@​1.13.2 ⏵ 1.16.087 -10100 +5010094100
Updatednpm/​@​datadog/​pprof@​5.9.0 ⏵ 5.14.192100100 +190100
Updatednpm/​@​google-cloud/​bigquery@​7.9.2 ⏵ 8.3.197100100 +191 +4100
Updatednpm/​firebase-admin@​13.2.0 ⏵ 13.9.093 +1100100 +193 +3100

View full report

@styfle styfle marked this pull request as ready for review May 12, 2026 20:10
@styfle styfle requested review from a team, icyJoseph and ijjk as code owners May 12, 2026 20:10
Co-authored-by: Steven <styfle@users.noreply.github.com>
@styfle styfle changed the title feat: support Node.js 26, drop 20 feat: support Node.js 26 May 12, 2026
cursoragent and others added 3 commits May 12, 2026 21:02
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants