feat: support Node.js 26#578
Open
styfle wants to merge 8 commits into
Open
Conversation
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
Co-authored-by: Steven <styfle@users.noreply.github.com>
ijjk
approved these changes
May 12, 2026
Co-authored-by: Steven <styfle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipOnNode26AndAbovephantomjs-prebuiltas a real devDependency and fixture for Node 20/22/24 coveragephantomjs-prebuiltfrom the Node 26 install manifest, since the PhantomJS fixture is skipped on Node 26 and its unsupported installer blocks Windows/macOS installsCoverage comparison
phantomjs-prebuilt: lines 91.03%, functions 96.36%, branches 88.31%phantomjs-prebuilt: tests pass, but functions drop to 95.75%Testing
npx npm@11.14.1 installnpx npm@11.14.1 run buildnpx npm@11.14.1 run prettier-checknpx jest --verbose test/unit.test.js -t "phantomjs-prebuilt|datadog-pprof-node-gyp"npx -y -p node@20 -c 'node -v && node node_modules/typescript/bin/tsc --sourceMap && node node_modules/jest/bin/jest.js --verbose test/unit.test.js -t "phantomjs-prebuilt|module-sync-condition-es-node20|module-sync-condition-cjs-node20"'npx npm@11.14.1 run test-verbosenpx -y -p node@26 -c 'node node_modules/typescript/bin/tsc --sourceMap && node node_modules/jest/bin/jest.js --verbose --coverage --globals "{\"coverage\":true}"'