Fix font alignment for the 'Add Text' tool#55
Merged
Conversation
Character glyphs in the textline were incorrectly aligned to the top when generating font previews in the 'Add Text' menu and in the pasted text bitmap. This commit fixes the glyph positioning in both the render_text() function and the calcTextBounds() helper function accordingly to how the glyph positioning is handled in `src/she/common/generic_surface.h`. Fixes #18
Nidrax
force-pushed
the
nidrax/fix-font-alignment
branch
from
2ceae02 to
ef2c4a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Character glyphs in the textline were incorrectly aligned to the top when generating font previews in the 'Add Text' menu and in the pasted text bitmap.
This commit fixes the glyph positioning in both the render_text() function and the calcTextBounds() helper function accordingly to how the glyph positioning is handled in
src/she/common/generic_surface.h.Fixes #18