Fix font size entry not accepting typed input in Add Text dialog#57
Closed
Copilot wants to merge 2 commits into
Closed
Fix font size entry not accepting typed input in Add Text dialog#57Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Remove she::set_input_rect({}) call from Entry kFocusLeaveMessage
handler. On Linux/X11, calling SDL_StopTextInput() followed immediately
by SDL_StartTextInput() (when focus moves from one Entry to another)
causes SDL_TEXTINPUT events to not fire reliably for the first keypress.
This meant unicodeChar stayed 0, so InsertChar was never triggered and
typed characters were silently dropped.
By not stopping SDL text input on focus leave, text input remains active
when transitioning between Entry widgets, ensuring SDL_TEXTINPUT fires
correctly and typed characters are properly inserted.
Fixes #56
Copilot
AI
changed the title
[WIP] Fix font size editing in Add Text menu
Fix font size entry not accepting typed input in Add Text dialog
Jun 15, 2026
Member
|
@copilot Nice try, but it does not solve the issue at all. Have you compared the changed files between the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The font size field in the Add Text dialog silently dropped typed characters on Linux/X11, making it impossible to change the value via keyboard.
Root Cause
The root cause is still under investigation. The initial hypothesis — that
Entry::onProcessMessagecallingshe::set_input_rect({})→SDL_StopTextInput()onkFocusLeaveMessagecaused an XIM reinitialisation delay — did not fully resolve the issue. Further comparison between thetrunkandls-developbranches is needed to identify which change introduced the regression.Fix
Investigation is ongoing. The current change removes
she::set_input_rect({})fromkFocusLeaveMessageinsrc/ui/entry.cpp, but this alone does not solve the problem.