Remove numeric string literals from translations JSONs#58
Merged
Conversation
This was referenced Jun 15, 2026
0e85fb9 added automatic string literal extractor for translations, adding a few new untranslated strings, one of them being "32" which is a set value of the `font_size` Entry field in the `data/widgets/paste_text.xml:11`, making it un-editable in-app once localized. This change removes the numeric string literals from translations: - "10" - "100" - "16" - "32" The string "180" remains in the files, being used for canvas rotation value in menus. The "Select Font" literal was also temporarily removed, because it caused to break the behavior of the font selection dropdown menu text that should display currently selected font name being overwritten by the i18n value. Fixes #56
Nidrax
force-pushed
the
nidrax/fix-non-editable-font-size
branch
from
56745ff to
a86151b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0e85fb9 added automatic string literal extractor for translations, adding a few new untranslated strings, one of them being "32" which is a set value of the
font_sizeEntry field in thedata/widgets/paste_text.xml:11, making it un-editable in-app once localized.This change removes the numeric string literals from translations:
The string "180" remains in the files, being used for canvas rotation value in menus.
The "Select Font" literal was also temporarily removed, because it caused to break the behavior of the font selection dropdown menu text that should display currently selected font name being overwritten by the i18n value.
Fixes #56