fix: Fix multiple filters handling in FilterBuilder by using CLI arguments instead of environment variables#5
Conversation
… in Rclone::withFilter This commit fixes a bug where `FilterBuilder::toFlags()` was being used to merge filters into the `$operation_flags` array, causing two problems: 1. When multiple includes/excludes were provided, they formed nested arrays (e.g., `['include' => ['*.txt', '*.jpg']]`) which triggered an `Array to string conversion` warning in `CommandBuilder::prefixFlags`. 2. Environment variables limit passing multiple identical flags to the rclone binary, effectively breaking multiple includes/excludes. The fix resolves this by calling `$this->filter->toArgs()` instead and merging those generated args into the sequential `$args` array, ensuring multiple `--include` or `--exclude` flags are passed correctly as CLI arguments. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
insign
deleted the
fix/filter-builder-multiple-includes-13853093892588867592
branch
1 participant
include/exclude) com oFilterBuilderna classeRclone. A alteração passa a injetar os filtros gerados peloFilterBuilder->toArgs()diretamente como argumentos de linha de comando no array$args, em vez de tentar processá-los como variáveis de ambiente, o que antes causava um aviso (Array to string conversion) no PHP e os anulava no Rclone.Flycloneperfeitamente funcional.PR created automatically by Jules for task 13853093892588867592 started by @insign