Feat/comittee applications#522
Open
HaakonMikalsen wants to merge 8 commits into
Open
Conversation
…orresponding pages
…tions # Conflicts: # src/app/committees/[shortName]/Nav.tsx # src/app/committees/[shortName]/layout.tsx # src/prisma/seeder/src/seeder.ts
JohanHjelsethStorstad
requested changes
Apr 15, 2026
…r side fix: spelling, language error, empty code and html hydration error
Contributor
Author
|
Thank you for all the feedback. I have unflattened the services, changed some names to be more clear, removed emty code and moved some checks to backend |
Member
|
I will take a look when I have time |
Member
JohanHjelsethStorstad
left a comment
JohanHjelsethStorstad
left a comment
There was a problem hiding this comment.
This is still strange
| import { FontAwesomeIcon } from '@fortawesome/react-fontawesome' | ||
| import { faLink } from '@fortawesome/free-solid-svg-icons' | ||
|
|
||
| type periodType = { |
There was a problem hiding this comment.
This type is strange to have here. Also it should be uppercased
There was a problem hiding this comment.
It is inherently the same as a type returned by the api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comittee application view for comittee members