Skip to content

update vite + storybook#124

Open
andreasN234 wants to merge 1 commit intomasterfrom
Upgrade-vite-and-storybook
Open

update vite + storybook#124
andreasN234 wants to merge 1 commit intomasterfrom
Upgrade-vite-and-storybook

Conversation

@andreasN234
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s build and component development tooling by upgrading Vite and Storybook to newer major/minor versions, and aligning the Vite library build config with the updated bundler options.

Changes:

  • Bump Storybook packages to 10.3.4 (including @storybook/react-vite).
  • Upgrade Vite to 8.0.5 and @vitejs/plugin-react to 6.0.1.
  • Update vite.config.mts to use build.rolldownOptions for configuring external dependencies.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
vite.config.mts Switches library build bundler options from rollupOptions to rolldownOptions to keep externals configured under the new Vite setup.
package.json Updates Vite/Storybook-related devDependencies to newer versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

formats: ['es'],
},
rollupOptions: {
rolldownOptions: {
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsconfig.json only includes src, so vite.config.mts isn’t type-checked by npm run type-check. Since this PR renames build.rollupOptions to build.rolldownOptions, a typo or unsupported option here could silently disable external handling and change the library bundle output. Consider adding a dedicated type-check step for vite.config.mts (or including config files in a separate tsconfig) to catch invalid config keys during CI.

Suggested change
rolldownOptions: {
rollupOptions: {

Copilot uses AI. Check for mistakes.
Comment on lines 110 to 113
"tslib": "2.8.1",
"typescript": "5.9.3",
"vite": "7.2.2",
"vite": "8.0.5",
"vite-plugin-dts": "4.5.4",
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping to vite@8.0.5 raises the required Node.js engine (^20.19.0 || >=22.12.0 per the installed package metadata). If your CI/dev environments rely on older Node versions, installs/builds will fail. Consider declaring an engines.node constraint in package.json (and/or updating CI tooling) so the requirement is explicit.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants