Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s build and component development tooling by upgrading Vite and Storybook to newer major/minor versions, and aligning the Vite library build config with the updated bundler options.
Changes:
- Bump Storybook packages to
10.3.4(including@storybook/react-vite). - Upgrade Vite to
8.0.5and@vitejs/plugin-reactto6.0.1. - Update
vite.config.mtsto usebuild.rolldownOptionsfor configuringexternaldependencies.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
vite.config.mts |
Switches library build bundler options from rollupOptions to rolldownOptions to keep externals configured under the new Vite setup. |
package.json |
Updates Vite/Storybook-related devDependencies to newer versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| formats: ['es'], | ||
| }, | ||
| rollupOptions: { | ||
| rolldownOptions: { |
There was a problem hiding this comment.
tsconfig.json only includes src, so vite.config.mts isn’t type-checked by npm run type-check. Since this PR renames build.rollupOptions to build.rolldownOptions, a typo or unsupported option here could silently disable external handling and change the library bundle output. Consider adding a dedicated type-check step for vite.config.mts (or including config files in a separate tsconfig) to catch invalid config keys during CI.
| rolldownOptions: { | |
| rollupOptions: { |
| "tslib": "2.8.1", | ||
| "typescript": "5.9.3", | ||
| "vite": "7.2.2", | ||
| "vite": "8.0.5", | ||
| "vite-plugin-dts": "4.5.4", |
There was a problem hiding this comment.
Bumping to vite@8.0.5 raises the required Node.js engine (^20.19.0 || >=22.12.0 per the installed package metadata). If your CI/dev environments rely on older Node versions, installs/builds will fail. Consider declaring an engines.node constraint in package.json (and/or updating CI tooling) so the requirement is explicit.
No description provided.