Fix misspell lint failure on main (strat → strategy)#18
Merged
Conversation
The misspell linter flags the standalone word strat as a typo of start, breaking the lint step on main. The helper is local to TestValidateStrategies and was the only standalone strat in the tree; rename it to strategy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI
golangci-lintstep is failing onmainafter PR #17 merged: themisspelllinter flags the standalone wordstratas a typo ofstartininternal/pack/pack_test.go.stratwas a local helper inTestValidateStrategiesand the only standalonestrattoken in the tree (production code usesStrategy/StrategyDescriptor, which misspell doesn't flag), so this renames just that helper tostrategyrather than whitelisting the word globally — a global ignore would mask genuinestrat→starttypos elsewhere.Verified locally:
golangci-lint run ./...clean,go build ./...,go test ./internal/pack/...pass.