Skip to content

fix: aggregate multi-space xref subsection support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 1 commit into from
Apr 24, 2026
Merged

fix: aggregate multi-space xref subsection support #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added samples/bugs/PullRequestXrefSubsectionMultipleSpaces.pdf
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/Smalot/PdfParser/RawData/RawDataParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ protected function decodeXref(string $pdfData, int $startxref, array $xref = [],
// initialize object number
$obj_num = 0;
// search for cross-reference entries or subsection
while (preg_match('/([0-9]+)[\x20]([0-9]+)[\x20]?([nf]?)(\r\n|[\x20]?[\r\n])/', $pdfData, $matches, \PREG_OFFSET_CAPTURE, $offset) > 0) {
while (preg_match('/([0-9]+)[\x20]+([0-9]+)[\x20]*([nf]?)(\r\n|[\x20]*[\r\n])/', $pdfData, $matches, \PREG_OFFSET_CAPTURE, $offset) > 0) {
if ($matches[0][1] != $offset) {
// we are on another section
break;
Expand Down
7 changes: 7 additions & 0 deletions tests/PHPUnit/Integration/DocumentIssueFocusTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,11 @@ public function testPDFDocEncodingDecode(): void
$testSubject = '•†‡…—–ƒ⁄‹›−‰„“”‘’‚™ŁŒŠŸŽıłœšž';
self::assertStringContainsString($testSubject, $details['Subject']);
}

public function testParseFileWithXrefSubsectionHavingMultipleSpaces(): void
{
$document = (new Parser())->parseFile($this->rootDir.'/samples/bugs/PullRequestXrefSubsectionMultipleSpaces.pdf');

self::assertCount(1, $document->getPages());
}
}
Loading