Skip to content

ci: add ecosystem PR smoke lane#27864

Merged
medvednikov merged 2 commits into
vlang:masterfrom
ulises-jeremias:ci/ecosystem-pr-smoke
Jul 20, 2026
Merged

ci: add ecosystem PR smoke lane#27864
medvednikov merged 2 commits into
vlang:masterfrom
ulises-jeremias:ci/ecosystem-pr-smoke

Conversation

@ulises-jeremias

Copy link
Copy Markdown
Member

Summary

This PR turns V Apps and Modules into a smaller PR smoke lane while preserving the current full ecosystem coverage for master pushes and scheduled runs.

  • Add a nightly schedule for full ecosystem coverage.
  • Keep the workflow name and existing job/check names unchanged.
  • Keep these representative checks on PRs in v-apps-compile:
    • vab
    • gitly
    • v-analyzer
    • msgpack
  • Run the heavier active ecosystem steps only outside pull_request events.
  • Add read-only workflow permissions because the workflow only needs repository reads.

Fixes #27843.

Why

The full ecosystem workflow clones and builds many external projects. Keeping all of that on every PR increases latency and external-network flakiness. This keeps useful PR signal from a smaller representative set while moving the full set to master and nightly scheduled coverage.

Validation

  • Parsed .github/workflows/v_apps_and_modules_compile_ci.yml with Ruby YAML.
  • Ran git diff --check.
  • Ran two AI code review passes; the first review found an implicit success() guard issue, and the follow-up review had no findings.

Local limitations:

  • rtk prettier --check .github/workflows/v_apps_and_modules_compile_ci.yml could not run because Corepack fails with the known package signature/keyid error before invoking Prettier.
  • actionlint is not installed locally.

Workflow Lint and GitHub Actions should provide final formatting and workflow validation in CI.

@ulises-jeremias

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35ed87fc7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/v_apps_and_modules_compile_ci.yml Outdated
@medvednikov

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 6daed5499a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@medvednikov
medvednikov merged commit b4ef100 into vlang:master Jul 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: split ecosystem compilation into PR smoke and full scheduled lanes

2 participants