🧪 Add missing tests for Engine inference functions#26
Conversation
- Add test for `Engine.decodeStep` to verify seq_pos and logits - Add test for `Engine.prefill` to verify multiple token processing - Add edge case test for `Engine.greedyNextToken` with negative logits Co-authored-by: ulac000000 <132948319+ulac000000@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What:
Engine.greedyNextTokenlacked edge case testing (such as handling all negative logits) and neighboring functionsdecodeStepandprefillwere entirely untested.📊 Coverage: Added test logic manually validating these engine functions with specifically initialized buffers to simulate decoding states properly.
✨ Result: Improved test coverage and reliability for core decoding functions within the Zig engine.
PR created automatically by Jules for task 3004043766962410542 started by @ulac000000