🧪 [Testing Improvement] Improve greedyNextToken test by initializing memory#35
🧪 [Testing Improvement] Improve greedyNextToken test by initializing memory#35
Conversation
Previously, the test only partially populated the logits array, leaving the remainder uninitialized. Because `std.testing.allocator` fills memory with `0xaa` in Debug builds (evaluating to `-3.03e-13` for `f32`), the test was susceptible to failing if an uninitialized value happened to be evaluated by `sampleGreedy`. This commit fully initializes the `logits` array with `-100.0` to ensure deterministic execution. Co-authored-by: ulac000000 <132948319+ulac000000@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The
Engine.greedyNextToken correctly identifies token with max logittest only populated the first 4 elements ofeng.logits, leaving the rest uninitialized. In Zig, uninitialized memory can cause indeterminate results or trigger bugs, especially sincestd.testing.allocatorwrites0xaabytes in debug mode.📊 Coverage: The test is now deterministic because
@memset(eng.logits, -100.0);fully initializes the memory slice, ensuring that only the explicitly specified max logit is returned.✨ Result: Improved test reliability and fixed a potential memory-related flakiness in the engine tests.
PR created automatically by Jules for task 6244411533397837354 started by @ulac000000