Skip to content

🧪 [Testing Improvement] Add negative logit tests for Engine.greedyNextToken#36

Open
void0x14 wants to merge 1 commit intomainfrom
jules/testing-greedy-next-token-14226148524933231579
Open

🧪 [Testing Improvement] Add negative logit tests for Engine.greedyNextToken#36
void0x14 wants to merge 1 commit intomainfrom
jules/testing-greedy-next-token-14226148524933231579

Conversation

@void0x14
Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed
This PR addresses the missing explicit test coverage for Engine.greedyNextToken when resolving sequences where logits fall into exclusively negative values (which are common prior to softmax passes with unnormalized projection weights).

📊 Coverage: What scenarios are now tested

  • The greedyNextToken behavior when all probabilities evaluated are functionally negative floats.
  • It correctly overrides internal uninitialized 0xaa memory filler during debug bounds testing by setting -100.0 over the slice explicitly, a known Zig standard allocator gotcha.

Result: The improvement in test coverage
The engine inference generation decode path (sampleGreedy) is now verified deterministic across both normal standard operations (positive values) and specific bounds (all negative values).


PR created automatically by Jules for task 14226148524933231579 started by @ulac000000

Adds a dedicated unit test in `src/inference/engine.zig` to ensure
that `Engine.greedyNextToken` accurately identifies the highest logit
when the entire logits array contains negative values. It explicitly
initializes the array using `@memset` to handle debug-mode padding
correctly.

Co-authored-by: ulac000000 <132948319+ulac000000@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant