🧪 Add negative testing for Engine.greedyNextToken#40
Conversation
Added an explicit test case to the `"Engine.greedyNextToken correctly identifies token with max logit"` test to ensure that the function handles scenarios where all array values are negative, specifically catching issues arising from memory fill patterns in zig debug allocators. Co-authored-by: ulac000000 <132948319+ulac000000@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The testing gap addressed
I noticed that
Engine.greedyNextTokenwas only tested for positive logits. This left a potential bug where if an array contained only negative or extremely small numbers (like whenstd.testing.allocatorfills memory with 0xaa), the greedy choice could fail.📊 Coverage: What scenarios are now tested
Added tests explicitly setting negative FP values in an array padded out with
-100.0.✨ Result: The improvement in test coverage
Engine.greedyNextTokenis now strictly verified to be robust against negative distributions in the output array.PR created automatically by Jules for task 17257759408583250986 started by @ulac000000