Repository navigation
Conversation
Recognize the existing scheme after leading whitespace while preserving canonical suffix characters and the existing shorthand/root branches. Cover public ls/read request URIs with successful-response regressions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Python SDK sends
viking://viking://resources/notesfor a canonical resource URI preceded by a space. Recognize the existing scheme after leading whitespace solsandreadretain one scheme.Human Involvement
Related Issue
Fixes #6445
Type of Change
Changes Made
viking://URI after removing leading whitespace.lsandreadrequest URIs.Testing
On Windows with Python 3.12.14 and httpx 0.28.1, using the exact SDK source component overlay and the existing SDK test file:
The full SDK suite and an actual OpenViking server, storage, or model integration were not run.
The local source-overlay harness was invoked with
python test_scripts/run_focused_pytest.py baseline baseline-nativeandpython test_scripts/run_focused_pytest.py fixed fixed-native. It passed the test file topytest.mainwith an empty local configuration and selectedresource_uri_normalization_preserves_canonical_suffix or ls_and_tree_preserve_query_options_and_pagination or glob_normalizes_scope_uri. This was a focused component run, not a full checkout test run. The public request reproduction is included in #6445.Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
This is a focused normalization fix. It adds no dependencies and leaves the existing shorthand branch intact. No additional documentation, explanatory code comments, or dependent change is required. The full-suite checkbox remains unchecked because validation was limited to the selected thirteen tests.