test(spark): characterize HadoopUtils S3 and Azure credential forwarding#8850
Open
jackylee-ch wants to merge 1 commit into
Open
test(spark): characterize HadoopUtils S3 and Azure credential forwarding#8850jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This was referenced Jul 20, 2026
Merging this PR will improve performance by 11.17%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
Signed-off-by: jackylee <qcsd2011@gmail.com>
jackylee-ch
force-pushed
the
spark-hadoop-utils-tests
branch
from
July 21, 2026 10:32
f8cb4b4 to
e4fa40e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
HadoopUtils(java/vortex-spark/src/main/java/dev/vortex/spark/config/HadoopUtils.java)is the bridge that forwards S3 and Azure credentials from the Spark session's Hadoop
Configurationinto the Vortex object-store property keys, and it currently has no testcoverage. A silently broken key mapping here doesn't fail loudly — it surfaces as
authentication errors (or unintentionally anonymous access via the Azure
skip_signaturefallback) only when running against real cloud storage. This continuesthe characterization-test series from #8770 (
ArrowUtils), #8782 (SparkToArrowSchema),and #8783 (
PartitionPathUtils).What changes are included in this PR?
A new
HadoopUtilsTestcovering both public methods:s3PropertiesFromHadoopConf: mapsfs.s3a.access.key/fs.s3a.secret.key/fs.s3a.session.token/fs.s3a.endpoint.regionto the correspondingaws_*keys;qualifies a bare
fs.s3a.endpointwithhttps://while preserving endpoints thatalready carry an
http://orhttps://scheme; ignores unrelated Hadoop keys andreturns an empty map for an empty configuration.
azurePropertiesFromHadoopConf: extracts the storage account key from anyfs.azure.account.key-prefixed entry and the SAS token from anyfs.azure.sas.fixed.token.-prefixed entry; setsazure_skip_signature=truewheneverno account key is present (including the SAS-token-only case); ignores unrelated
fs.azure.*keys.This is a test-only change; no production code is modified. 10 tests, passing
locally on both matrix legs (
:vortex-spark_2.12:testand:vortex-spark_2.13:testwith
--tests 'dev.vortex.spark.config.HadoopUtilsTest').What APIs are changed? Are there any user-facing changes?
None. No production code or public API is touched.