feat[edition]: session-registered editions defitions#8871
Merged
Conversation
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (11)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: Vortex queries 📖Verdict: Likely regression (medium confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.332x ❌, 0↑ 2↓)
datafusion / parquet (1.102x ❌, 0↑ 1↓)
duckdb / vortex-file-compressed (1.131x ❌, 0↑ 2↓)
duckdb / parquet (1.079x ➖, 0↑ 1↓)
No file size changes detected. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
joseph-isaacs
force-pushed
the
claude/editions-impl-fiicrg
branch
from
July 21, 2026 09:35
b653c99 to
bb67435
Compare
joseph-isaacs
changed the title
joseph-isaacs
force-pushed
the
claude/editions-impl-fiicrg
branch
4 times, most recently
from
July 21, 2026 09:50
89bcb4a to
528cd3f
Compare
joseph-isaacs
marked this pull request as draft
July 21, 2026 09:56
joseph-isaacs
force-pushed
the
claude/editions-impl-fiicrg
branch
2 times, most recently
from
July 21, 2026 10:07
a07aa2e to
a4f07a8
Compare
joseph-isaacs
changed the title
…tex facade vortex-edition provides the editions machinery: the types (EditionId, Edition, EditionInclusion, EditionDeclaration), the EditionSession session variable holding the per-session registry (starts empty; clones share the registry like other session registries), computation (editions(), encodings_in() with membership inherited by later editions of the family, current()), validation (identifier/version forms via EditionId::validate and EditionInclusion::validate, plus whole-registry checks: undeclared references, drafts-newest chronology, members requiring a release newer than their edition declares), and the validate!(session, EDITION) macro generating a per-edition unit test. Encoding ids use the session's intern pool (registry::Id, the same identifier space as ArrayId), and declaration blocks name encodings via the AsEncodingId trait — an id string today, an encoding vtable once vortex-array implements it. The actual declarations live in the public vortex crate (vortex::editions): two core editions declared block-wise with the encodings each adds — core2026.01.0 with the 12 canonical encodings and core2026.07.0 inheriting them plus the 20 container/compressed encodings the default writer emits. Both are drafts until their min_vortex_version is recorded, which is the act of freezing. register_default_editions seeds them into the default session, golden tests pin both sets, and transitivity/consistency tests cover inheritance and the one-inclusion-per-encoding invariant. Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KdR42Svu74NcNzC7XJYwLr
joseph-isaacs
force-pushed
the
claude/editions-impl-fiicrg
branch
from
July 21, 2026 10:13
a4f07a8 to
07e5746
Compare
joseph-isaacs
changed the title
joseph-isaacs
marked this pull request as ready for review
July 21, 2026 10:50
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
robert3005
approved these changes
Jul 21, 2026
robert3005
left a comment
robert3005
left a comment
Contributor
There was a problem hiding this comment.
only had one question
| fn encoding_id(&self) -> Id; | ||
| } | ||
|
|
||
| impl AsEncodingId for str { |
Contributor
There was a problem hiding this comment.
Do we use this impl anywhere?
Contributor
Author
There was a problem hiding this comment.
I think that is used for each definition since they are defined by strs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Any encoding that vortex will write using built-in layout strategies or compressors will come from an edition.
What changes are included in this PR?
vortex-editionscrate and session variable.