Fix CUDA ListView dictionary export regression test#8876
Conversation
Signed-off-by: Onur Satici <onur@spiraldb.com>
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Benchmarks: Vortex queries 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.974x ➖, 0↑ 0↓)
datafusion / parquet (0.900x ✅, 1↑ 0↓)
duckdb / vortex-file-compressed (0.905x ➖, 1↑ 0↓)
duckdb / parquet (0.978x ➖, 0↑ 0↓)
No file size changes detected. |
Merging this PR will improve performance by 18.4%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | cuda/bitpacked_u8/unpack/3bw[100M] |
354.9 µs | 299.8 µs | +18.4% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing os/test-fix (46cb0d2) with develop (c66add6)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Rationale for this change
The PiecewiseSequence ListView rebuild now preserves dictionary encoding for large lists. The cuda export regression test still expected the previous, incidentally canonicalised Int32 child layout