Skip to content

Fix CUDA ListView dictionary export regression test#8876

Merged
onursatici merged 1 commit into
developfrom
os/test-fix
Jul 21, 2026
Merged

Fix CUDA ListView dictionary export regression test#8876
onursatici merged 1 commit into
developfrom
os/test-fix

Conversation

@onursatici

Copy link
Copy Markdown
Contributor

Rationale for this change

The PiecewiseSequence ListView rebuild now preserves dictionary encoding for large lists. The cuda export regression test still expected the previous, incidentally canonicalised Int32 child layout

Signed-off-by: Onur Satici <onur@spiraldb.com>
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done 46cb0d2 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries 📖

Verdict: No clear signal (low confidence)
Attributed Vortex impact: +0.1%
Engines: DataFusion No clear signal (+8.2%, medium confidence) · DuckDB No clear signal (-7.5%, medium confidence)
Vortex (geomean): 0.938x ➖
Parquet (geomean): 0.938x ➖
Shifts: Parquet (control) -6.2% · Median polish -6.1%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (0.974x ➖, 0↑ 0↓)
name PR 46cb0d2 (ns) base e767a30 (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 9449016 9825439 0.96
vortex_q01/datafusion:vortex-file-compressed 6292945 6382956 0.99
datafusion / parquet (0.900x ✅, 1↑ 0↓)
name PR 46cb0d2 (ns) base e767a30 (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 19291380 21147036 0.91
vortex_q01/datafusion:parquet 🚀 4513977 5088668 0.89
duckdb / vortex-file-compressed (0.905x ➖, 1↑ 0↓)
name PR 46cb0d2 (ns) base e767a30 (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 9994702 10812350 0.92
vortex_q01/duckdb:vortex-file-compressed 🚀 5715422 6455096 0.89
duckdb / parquet (0.978x ➖, 0↑ 0↓)
name PR 46cb0d2 (ns) base e767a30 (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23199329 23704975 0.98
vortex_q01/duckdb:parquet 9348956 9561482 0.98

No file size changes detected.

@codspeed-hq

codspeed-hq Bot commented Jul 21, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 18.4%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 1838 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime cuda/bitpacked_u8/unpack/3bw[100M] 354.9 µs 299.8 µs +18.4%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing os/test-fix (46cb0d2) with develop (c66add6)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@onursatici
onursatici merged commit 6a79bcf into develop Jul 21, 2026
85 of 86 checks passed
@onursatici
onursatici deleted the os/test-fix branch July 21, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants