Back EnabledEditions with a session Registry - #8956
Merged
Merged
Conversation
joseph-isaacs
marked this pull request as ready for review
July 24, 2026 16:06
joseph-isaacs
force-pushed
the
claude/arcswap-enabled-editions-8yi6tk
branch
from
July 24, 2026 16:09
0fc9544 to
45e8bf4
Compare
Contributor
|
👀 |
robert3005
reviewed
Jul 27, 2026
0ax1
approved these changes
Jul 27, 2026
0ax1
left a comment
0ax1
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable. In general, editions seem to be able to be a bit more dynamic than I thought they'd need to be. As in, my assumption would that editions are initialized at runtime once but then constant.
joseph-isaacs
force-pushed
the
claude/arcswap-enabled-editions-8yi6tk
branch
from
July 27, 2026 10:18
45e8bf4 to
8021e73
Compare
joseph-isaacs
changed the title
Replace the Arc<RwLock<BTreeMap>> behind EnabledEditions with the shared Registry<EditionId> used by the other session variables (array encodings, scalar functions, layouts, dtypes), keyed by edition family. Enabling an edition maps to Registry::register, which replaces the family's previous entry, matching the "at most one edition per family" semantics. The family &'static str is interned via Into<Id> only at enable time, a rare config-time write, so the disallowed hot-path interning does not apply. editions() no longer guarantees an ordering; the one test that asserted a specific order sorts the result itself. Signed-off-by: Joseph Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
claude/arcswap-enabled-editions-8yi6tk
branch
from
July 27, 2026 10:19
8021e73 to
cb0066c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Replace the
RwLock-backedBTreeMapbehindEnabledEditionswith the sharedRegistry<EditionId>used by the other session variables (array encodings, scalar functions,layouts, dtypes), keyed by edition family.
Enabling an edition maps to
Registry::register, which replaces the family's previous entry —matching the "at most one edition per family" semantics directly. The family
&'static strisinterned via
Into<Id>only at enable time (a rare config-time write), so the disallowedhot-path interning does not apply.
editions()no longer guarantees an ordering; the one test that asserted a specific order sortsthe result itself.