Adjust strict docs - #9033
Open
connortsui20 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
| /// 1. Output validity is precomputable as the `AND` of the input validities, so | ||
| /// `valid(f(a1, .., ak)) = valid(a1) ∧ .. ∧ valid(ak)`. | ||
| /// 1. Any null input slot nulls the output slot, so the output validity is bounded above by the | ||
| /// `AND` of the input validities: `valid(f(a1, .., ak)) ⊆ valid(a1) ∧ .. ∧ valid(ak)`. |
Contributor
There was a problem hiding this comment.
is it a bound or equal?
Member
Author
There was a problem hiding this comment.
bounded, thats why there is a subset there.
formally, g is allowed to return a null even if its inputs are not null. This is subtly different from how f MUST return null if any inputs ARE null.
Comment on lines
201
to
205
| @@ -203,8 +205,8 @@ pub trait ScalarFnVTable: 'static + Sized + Clone + Send + Sync { | |||
| /// f(v1, .., vk) = g(v1, .., vk) otherwise | |||
Contributor
There was a problem hiding this comment.
this not contradicts the below
Member
Author
There was a problem hiding this comment.
why does it contradict the stuff below?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the semantics of strictness for the list scalar fns were unclear.