fix: validate unsigned AVX2 take indices - #9036
Open
connortsui20 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
marked this pull request as ready for review
July 28, 2026 16:35
Member
Author
|
I wonder if we its better to just always mask it out instead of checking for better perf? do we even allow take indices larger than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix AVX2 primitive take bounds checks for unsigned indices. AVX2 exposes signed integer comparisons (
_mm256_cmpgt_epi32/_mm256_cmpgt_epi64), not unsigned equivalents, and its gather instructions interpret offsets as signed integers. XOR-bias before comparing, pass the resulting valid mask to the gather, and panic before gathering if a lane is invalid. Without the mask, an out-of-bounds gather is undefined behavior. A length that does not fit in its index type means every representable index is valid.Why this matters