All true constant mask reduces to nullability cast - #9038
Draft
mhk197 wants to merge 1 commit into
Draft
Conversation
mhk197
marked this pull request as draft
July 28, 2026 16:39
github-actions
Bot
removed
the
action/benchmark-sql
Contributor
Benchmarks: Clickbench on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.913x ➖, 17↑ 1↓)
datafusion / parquet (0.924x ➖, 12↑ 0↓)
duckdb / vortex-file-compressed (0.934x ➖, 6↑ 0↓)
duckdb / parquet (0.968x ➖, 0↑ 1↓)
File Size Changes (101 files changed, -39.2% overall, 0↑ 101↓)
Totals:
|
Contributor
Benchmarks: FineWeb S3 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.992x ➖, 0↑ 0↓)
datafusion / parquet (0.928x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.977x ➖, 0↑ 0↓)
duckdb / parquet (1.008x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=1 on S3 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.935x ➖, 1↑ 0↓)
datafusion / parquet (0.928x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.988x ➖, 0↑ 0↓)
duckdb / parquet (0.971x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=1 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.074x ➖, 0↑ 2↓)
datafusion / parquet (1.028x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (1.041x ➖, 0↑ 0↓)
duckdb / parquet (1.046x ➖, 1↑ 4↓)
File Size Changes (10 files changed, -43.9% overall, 0↑ 10↓)
Totals:
|
Contributor
Benchmarks: PolarSignals Profiling 📖Vortex (geomean): 1.328x ❌ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.328x ❌, 0↑ 10↓)
File Size Changes (1 files changed, -8.2% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: Clickbench Sorted on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.923x ➖, 3↑ 1↓)
datafusion / parquet (0.948x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.944x ➖, 2↑ 0↓)
duckdb / parquet (0.991x ➖, 0↑ 0↓)
File Size Changes (201 files changed, -42.8% overall, 45↑ 156↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.020x ➖, 0↑ 0↓)
datafusion / parquet (1.005x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.083x ➖, 0↑ 10↓)
duckdb / parquet (1.012x ➖, 0↑ 0↓)
File Size Changes (25 files changed, -44.0% overall, 0↑ 25↓)
Totals:
|
Contributor
Benchmarks: FineWeb NVMe 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.988x ➖, 0↑ 0↓)
datafusion / parquet (1.004x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.994x ➖, 1↑ 0↓)
duckdb / parquet (0.997x ➖, 0↑ 0↓)
File Size Changes (2 files changed, -46.3% overall, 0↑ 2↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.171x ❌, 0↑ 93↓)
datafusion / parquet (1.131x ❌, 0↑ 66↓)
duckdb / vortex-file-compressed (1.114x ❌, 0↑ 58↓)
duckdb / parquet (1.086x ➖, 0↑ 32↓)
File Size Changes (25 files changed, -43.5% overall, 0↑ 25↓)
Totals:
|
Contributor
Benchmarks: Statistical and Population Genetics 📖Verdict: Likely improvement (high confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (0.733x ✅, 9↑ 0↓)
duckdb / parquet (0.986x ➖, 0↑ 0↓)
File Size Changes (3 files changed, -42.8% overall, 0↑ 3↓)
Totals:
|
mhk197
added
action/bench-sql
github-actions
Bot
removed
the
action/benchmark-sql
Merging this PR will improve performance by 16.63%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | cuda/bitpacked_u8/unpack/3bw[100M] |
350.6 µs | 300.6 µs | +16.63% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mk/constant-true-mask-reduce (b23aea0) with develop (6609288)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
force-pushed
the
mk/constant-true-mask-reduce
branch
from
July 28, 2026 17:32
81f5ac8 to
b23aea0
Compare
github-actions
Bot
removed
the
action/benchmark-sql
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A true constant mask should reduce to a nullability cast without changing any array data.