Remove bloom filters from TPC-H data - #9048
Open
AdamGS wants to merge 1 commit into
Open
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
joseph-isaacs
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR aligns our TPC-H based benchmark to what other setups usually do.
TPC-H data is usually generated without bloom filters, which we currently enable unconditionally.
In addition, the common benchmark for this data (at the scales we use) uses a single file per table.
This PR supersedes #9037.
What APIs are changed? Are there any user-facing changes?
None