Added sonar segmentation projection with sim and image sementation fo…#52
Open
eirisak wants to merge 20 commits into
Open
Added sonar segmentation projection with sim and image sementation fo…#52eirisak wants to merge 20 commits into
eirisak wants to merge 20 commits into
Conversation
jorgenfj
previously approved these changes
Mar 22, 2026
jorgenfj
left a comment
Contributor
There was a problem hiding this comment.
lgtm.
replace ci_install_dependencies.sh with this script to install stonefish https://github.com/vortexntnu/vortex-stonefish-sim/blob/main/scripts/ci_install_dependencies.sh
and add stonefish_ros2 to dependencies.repos to get CI to pass
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 6 8 +2
Lines 321 539 +218
Branches 36 55 +19
======================================
- Misses 321 539 +218
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jorgenfj
previously approved these changes
Mar 25, 2026
jorgenfj
left a comment
Contributor
There was a problem hiding this comment.
Should make the name of the stonefish respawn service a ros param.
Other than that LGTM
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sonar segmentation dataset creation and sonar segmentation function to segmentation node.