Skip to content

Added sonar segmentation projection with sim and image sementation fo…#52

Open
eirisak wants to merge 20 commits into
mainfrom
sonar-segmentation-projection
Open

Added sonar segmentation projection with sim and image sementation fo…#52
eirisak wants to merge 20 commits into
mainfrom
sonar-segmentation-projection

Conversation

@eirisak

@eirisak eirisak commented Mar 22, 2026

Copy link
Copy Markdown

Sonar segmentation dataset creation and sonar segmentation function to segmentation node.

@eirisak eirisak requested a review from jorgenfj March 22, 2026 15:48
@eirisak eirisak self-assigned this Mar 22, 2026
jorgenfj
jorgenfj previously approved these changes Mar 22, 2026

@jorgenfj jorgenfj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
replace ci_install_dependencies.sh with this script to install stonefish https://github.com/vortexntnu/vortex-stonefish-sim/blob/main/scripts/ci_install_dependencies.sh
and add stonefish_ros2 to dependencies.repos to get CI to pass

Comment thread stonefish_labeling/sonar_segmentation/config/sonar_segmentation.yaml Outdated
@vortexuser vortexuser linked an issue Mar 22, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Mar 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 260 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (34a3fee) to head (9d8c24e).

Files with missing lines Patch % Lines
...sonar_segmentation/src/sonar_segmentation_node.cpp 0.00% 177 Missing ⚠️
...ntation/vortex_image_segmentation/yolo_seg_node.py 0.00% 77 Missing ⚠️
stonefish_labeling/sonar_segmentation/src/main.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main     #52    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          6       8     +2     
  Lines        321     539   +218     
  Branches      36      55    +19     
======================================
- Misses       321     539   +218     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
stonefish_labeling/sonar_segmentation/src/main.cpp 0.00% <0.00%> (ø)
...ntation/vortex_image_segmentation/yolo_seg_node.py 0.00% <0.00%> (ø)
...sonar_segmentation/src/sonar_segmentation_node.cpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jorgenfj
jorgenfj previously approved these changes Mar 25, 2026

@jorgenfj jorgenfj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should make the name of the stonefish respawn service a ros param.
Other than that LGTM

Comment thread stonefish_labeling/sonar_segmentation/src/sonar_segmentation_node.cpp Outdated
@kluge7 kluge7 linked an issue Apr 11, 2026 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend instance segmentation to support Sonar info msgs [TASK] Sonar segmentation/detection support

2 participants