Fix/remove grid#21
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 27 27
Lines 694 708 +14
Branches 51 51
=====================================
- Misses 694 708 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
kluge7
requested changes
Apr 8, 2026
Clarified comments for hsv saturation and value adjustments.
AntTra
commented
Apr 16, 2026
Clarify the calculation of threshold value in the apply_filter method.
kluge7
added a commit
that referenced
this pull request
Jun 9, 2026
* three different thresholding methods added * implemented HSV tuning * added tuning comments in params and const in some values * Update comments in image_filtering_params.yaml Clarified comments for hsv saturation and value adjustments. * Update comment for threshold calculation in BinaryThreshold Clarify the calculation of threshold value in the apply_filter method. * chore: apply pre-commit formatting --------- Co-authored-by: Andreas Kluge Svendsrud <89779148+kluge7@users.noreply.github.com> Co-authored-by: Sophia Mina Friedensburg <pianist.sophia.friedensburg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thresholding dependent on HSV instead of single green channel. Changed order of operations to thresholding -> inpaint -> optional binary thresholding