Repository navigation
fix(compat): preserve query error callback semantics - #1623
Merged
Merged
Conversation
✅ Deploy Preview for vue-apollo-5 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
nickmessing
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the default
errorPolicy: 'none', compat currently forwards failed query states toonResult. Besides reporting a failed refetch as a result, this makes compatuseLazyQuery().load()resolve withundefinedbeforeonErrorcan reject it.Restore v4.2.2's error handling by skipping these states in compat
onResult. The guard uses the observable query's effective error policy, so client defaults and query overrides are respected. Partial results forallandignorestill pass through; native v5 events are unchanged.Confirmed the behavior difference against v4.2.2 + Apollo Client 3.13.9 for both network and GraphQL failures. The new tests cover failed refetches, successful retries, lazy-load rejection, policy precedence, and partial results: 12 cases fail before the fix, while the 4 partial-result controls already pass.
Validation: all 122 composable tests, composable typecheck/build, and repository lint pass.