feat: implement Plan-01 Data Model#1
Open
martyy-code wants to merge 10 commits into
Open
Conversation
martyy-code
force-pushed
the
feature/plan-01-data-model
branch
from
16f2ab4 to
ab1a70f
Compare
codewizdave
reviewed
May 28, 2026
| .handler(async ({ input }) => { | ||
| return queries.certification.getByIdWithDetails(input.id) | ||
| }) | ||
|
|
Contributor
There was a problem hiding this comment.
One method with optionnal param pls
Contributor
There was a problem hiding this comment.
caces, medical visits, ... should be in separate files
| return queries.warehouse.update(input.id, { name: input.name }) | ||
| }) | ||
|
|
||
| const deleteWarehouse = os |
Contributor
There was a problem hiding this comment.
why suffix only on this procedure ?
| return queries.role.update(input.id, { name: input.name }) | ||
| }) | ||
|
|
||
| const deleteRole = os |
Contributor
There was a problem hiding this comment.
maybe internal ts name ?
Comment on lines
+7
to
+17
| .input(z.object({ | ||
| firstName: z.string(), | ||
| lastName: z.string(), | ||
| email: z.string().optional(), | ||
| phone: z.string().optional(), | ||
| arrivalDate: z.string(), | ||
| contractType: z.enum(contractTypesList as [string, ...string[]]), | ||
| roleId: z.string(), | ||
| warehouseId: z.string() | ||
| })) | ||
| .handler(async ({ input }) => { |
Contributor
There was a problem hiding this comment.
why not drizzle type ? Could check drizzle-zod with fresh
Contributor
There was a problem hiding this comment.
should create a alerts folder with file for each alterts types
Complete data model for WEMS (Warehouse Employee Management System): - Drizzle ORM schema with soft delete support for Role, Warehouse, CertificationType, Certification - oRPC API procedures for all CRUD operations - Modular folder structure for procedures and queries Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
martyy-code
force-pushed
the
feature/plan-01-data-model
branch
from
e66f86f to
222b73f
Compare
The prepare script triggers a build during pnpm install, but API's dist files haven't been generated yet. The CI explicitly builds packages in order, so prepare is redundant. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Fix import paths in router.ts to use new folder structure under ./procedures/certifications/ - Add packages/*/dist to .gitignore to exclude build outputs Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Build ordering: - Add db build step before api build in CI workflows - Add db + api build steps before SDK in CI workflows Lint fixes: - Ignore test files in eslint config (*.test.ts, *.spec.ts) - Remove unused imports from queries.test.ts - Remove unused NewEmployee and searchLower from employee.ts - Remove unused NewRole from role.ts Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The API procedures directly import drizzle-orm for eq(), but drizzle-orm was only listed in db package. This caused TypeScript to fail finding the module. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Lint fixes: - Update eslint config to ignore dist, handle _ prefixed unused vars - Add no-unsafe-* rules to allow proxy pattern - Change lint file pattern from **/*.ts to src/**/*.ts TypeScript fixes: - Add Record<string, any> type alias for db proxy - Add drizzle-orm dependency to API package - Prefix unused employeeId params with _ in caces, medical - Remove unused NewDrivingAuthorization, NewOnlineTraining imports Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
All workflows that depend on packages/db, api, or sdk now build those packages first before running their own build/typecheck/lint. This fixes the "Cannot find module" errors when CI ran workflows in parallel without ensuring dependencies were built first. Modified workflows: - typecheck-desktop.yml - build-desktop.yml - build-web.yml - lint-desktop.yml - lint-api.yml - test-web.yml Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- lint.yml (Web): build db, api, sdk before web lint - lint-sdk.yml: build db, api before sdk lint Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add drizzle-zod dependency to packages/db - Create packages/db/src/schemas.ts with auto-generated schemas from Drizzle tables - Update API procedures to use schemas from drizzle-zod (role, warehouse, employee) - Fix lint scripts to only lint src/, not dist/ (build output) - Fix TypeScript issues in initDb.ts with eslint-disable for runtime db proxy Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
All CI workflows now run on push and PR to both main and dev branches. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queries.role.create(),queries.employee.list()Test plan
Technical Details
@electron-template/db@electron-template/api@electron-template/sdkTables Created
🤖 Generated with Claude Code