-
Notifications
You must be signed in to change notification settings - Fork 17
docs: add written procedures to Ollama and PR review guides #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rachaelrenk
wants to merge
11
commits into
main
Choose a base branch
from
rrenk/guides-written-procedures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+280
−102
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2f3501e
docs: add written procedures to Ollama and PR review guides
rachaelrenk 68b4387
fix: correct factual errors in Ollama guide after review
rachaelrenk a751589
Update src/content/docs/guides/external-tools/how-to-set-up-ollama.mdx
rachaelrenk 01f33ca
Update src/content/docs/guides/agent-workflows/how-to-review-prs-like…
rachaelrenk e0e49c5
Merge branch 'main' into rrenk/guides-written-procedures
rachaelrenk a439052
Apply suggestion from @rachaelrenk
rachaelrenk 2717d4a
fix: address PR review comments
rachaelrenk 391a6a8
fix: correct 6 factual errors found in full truthiness review
rachaelrenk 1013809
Merge branch 'main' into rrenk/guides-written-procedures
rachaelrenk 2063047
refactor: restructure PR review guide per hongyi-chen feedback
rachaelrenk 845261a
Merge branch 'main' into rrenk/guides-written-procedures
rachaelrenk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rethink the framing here. Right now this reads like “paste this giant template and get a senior-engineer-quality review,” which feels a bit heavy handed.
A stronger guide would focus on the actual workflow:
The structured output can still be useful, but it should support the review process rather than be the main point of the guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few specific changes:
gh pr diffonly gives the patch.gh pr view, the checked-out-branch, tests, etc, would provide more contextgenerally, i think we can simplify this instead of recommending such a specific step by step guide to code review