Skip to content

fix: capture PR URL before composing Slack notification message #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dannyneira wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: capture PR URL before composing Slack notification message #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1547fa2
fix: capture PR URL before composing Slack notification message
dannyneira Jul 10, 2026
3b83c3a
fix: skip Slack notification gracefully when no PR was created
dannyneira Jul 10, 2026
5b2fbc2
Merge branch 'main' into fix/slack-pr-url-capture
dannyneira Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .agents/skills/release_updates/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,19 @@ python3 .agents/skills/release_updates/scripts/run_release_updates.py \
After the PR is created, post a notification to the `#oncall-client` Slack channel (`C06MT1NRBFV`):

```python
import json, os, sys, urllib.request
import json, os, subprocess, sys, urllib.request

# Capture the URL of the PR you just created.
# If no PR exists (no-op run with no docs changes), skip silently.
try:
pr_url = subprocess.check_output(
['gh', 'pr', 'view', '--json', 'url', '--jq', '.url'],
text=True, stderr=subprocess.DEVNULL
).strip()
except subprocess.CalledProcessError:
print('No PR found — skipping Slack notification (no-op run)')
sys.exit(0)

# pr_url: obtain from the PR created in the previous step, e.g.:
# pr_url = subprocess.check_output(['gh', 'pr', 'view', '--json', 'url', '--jq', '.url'], text=True).strip()
token = os.environ.get('DOCS_SLACK_BOT_TOKEN')
channel = 'C06MT1NRBFV' # #oncall-client
if not token:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-docs-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ jobs:
PY

# Installs the stable oz CLI and runs the release_updates skill in the
# release-docs Oz environment (K5KStCm5aYvhfBJb8cHol6), which has
# DOCS_AGENT_GRAFANA_TOKEN configured for on-call reviewer assignment.

@MaggieShan MaggieShan Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we mean to remove the comment about the grafana token?

@dannyneira dannyneira Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, no longer using the DOCS_AGENT_GRAFANA_TOKEN anymore in this automation.

I'm justing using the slack @oncall-client-primary/secondary since they already setup to notify the right people

@dannyneira dannyneira Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a docs bot slack token now to send the messages to #oncall-client :)

# release-docs Oz environment (K5KStCm5aYvhfBJb8cHol6).
# WARP_API_KEY is the Docs Agent's API key.
# DOCS_SLACK_BOT_TOKEN must be added to the environment for Slack notifications.
- name: Install Oz CLI
run: |
curl -sL "https://app.warp.dev/download/cli?os=linux&package=deb&arch=x86_64" -o /tmp/oz.deb
Expand Down
Loading