Fix New worktree config clipping in tab config menu#10542
Conversation
The horizontal tab-bar chevron menu used the 186px default width while the vertical-tab variant used 268px. Both render the same unified_new_session_menu_items, and 186px is too narrow for the "New worktree config" label. Always use 268px. Fixes warpdotdev#10269
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the unified new-session/tab config menu to use the same 268px width for both horizontal chevron and vertical-tab entry points, which addresses clipping for the longer New worktree config label. The removed MENU_DEFAULT_WIDTH import follows from no longer using the narrower default in this path.
Concerns
- None.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
oz-for-oss
Bot
requested review from
a team and
alokedesai
and removed request for
a team
|
@alokedesai could you take a look here? A very small UI change |
|
@moirahuang mind reviewing this one? I don't have full context on why the initial change was scoped just for vertical tabs |
moirahuang
left a comment
moirahuang
left a comment
There was a problem hiding this comment.
thanks for making this change!
Now that both menu variants share the same width, the is_vertical_tabs field on the ToggleNewSessionMenu action and the parameter threaded through open_tab_configs_menu / toggle_new_session_dropdown_menu serve no purpose. Remove them along with the redundant explanatory comment.
…ktree-config-clipping
|
@moirahuang Made the necessary changes, please re-review |
moirahuang
left a comment
moirahuang
left a comment
There was a problem hiding this comment.
thanks for making this change!
|
@SagarSDagdu Please address the formatting CI errors and then I'll merge! |
3 participants
Description
Fixes the clipping of
New worktree configin the unified new-session/tab config menu opened from the horizontal tab-bar chevron.The chevron variant used
MENU_DEFAULT_WIDTH(186px) while the vertical-tab+variant already used 268px. Both branches render the sameunified_new_session_menu_items, and 186px is too narrow for the longer label. Both variants now use 268px.Linked Issue
Fixes #10269
ready-to-implement.Screenshots / Videos
Before
After
Testing
cargo check -p warppasses.cargo run -p warp --bin warp-oss) launches; attached before/after screenshots of the chevron menu in horizontal-tab mode withTabConfigsenabled.Agent Mode
CHANGELOG-BUG-FIX: Fix
New worktree configclipping in the tab-bar new-session menu.