Hide third-party transcript vehicle conversations from the management view.#10779
Hide third-party transcript vehicle conversations from the management view.#10779liliwilson wants to merge 2 commits into
Conversation
liliwilson
force-pushed
the
lili/app-4418-restoring-3rd-party-cloud-agent-conversations-creates-ghost
branch
from
be87744 to
898ff56
Compare
liliwilson
changed the base branch from
master
to
fix-restored-cli-agent-pane-title
liliwilson
force-pushed
the
lili/app-4418-restoring-3rd-party-cloud-agent-conversations-creates-ghost
branch
from
898ff56 to
26e13e8
Compare
| ctx: &mut ViewContext<Self>, | ||
| ) -> Option<AIConversationId> { | ||
| let origin = AgentViewEntryOrigin::ThirdPartyCloudAgent; | ||
| let conversation_id = BlocklistAIHistoryModel::handle(ctx).update(ctx, |history, ctx| { |
There was a problem hiding this comment.
We can create the convo within the agent view, this movement is supposed to be a noop change
liliwilson
force-pushed
the
lili/app-4418-restoring-3rd-party-cloud-agent-conversations-creates-ghost
branch
from
26e13e8 to
9bdc7ac
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
liliwilson
force-pushed
the
lili/app-4418-restoring-3rd-party-cloud-agent-conversations-creates-ghost
branch
2 times, most recently
from
5721363 to
5487de9
Compare
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds a marker for third-party transcript vehicle conversations and excludes those conversations from navigation/management surfaces.
Concerns
- The new
is_cli_agent_transcriptaccessor does not compile: it takes&mut self, omits the-> boolreturn type, and is called fromshould_exclude_from_navigation(&self).
Verdict
Found: 1 critical, 0 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
liliwilson
force-pushed
the
lili/app-4418-restoring-3rd-party-cloud-agent-conversations-creates-ghost
branch
from
5487de9 to
5084a0c
Compare
| ); | ||
| if matches!(origin, AgentViewEntryOrigin::ThirdPartyCloudAgent) { | ||
| if let Some(conversation) = history_model.conversation_mut(&id) { | ||
| conversation.mark_as_cli_agent_transcript(); |
There was a problem hiding this comment.
lets just make this a constructor arg so u never need to reason about this state being mutable (which the API implies)
2 participants
Description
When restoring third-party conversation transcripts, we create a vehicle
AIConversationthat we use to enter the agent view.We used to be rendering these
AIConversationentries within management surfaces throughout the app, resulting in ghost entries in the management view that got created every time you tried to restore a CLI transcript.We fix this here by tracking when an
AIConversationis being used as a CLI vehicle (which we set based on theAgentEntryOrigin) and add these to the existingshould_exclude_from_navigation.We didn't see this for live sessions, even though they also use vehicle conversations, because we already check in
should_exclude_from_navigationwhether we are viewing a shared session.Testing
Tested locally: https://www.loom.com/share/20b9e025ab9c49f49c21a929ab702d25
./script/runAgent Mode