Cloud mode v2: unify no-auth-secret label#10783
Conversation
…rom environment" Previously the menu showed "No secret" while the selected-button label showed "No API key" for the same state. Use a single, more descriptive label in both places so the empty-selection state is consistent. Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR centralizes the no-auth-secret label so the selector button and menu item use the same user-facing copy.
Concerns
- The implemented copy uses
Inherit from environment, while the PR description says the intended text isInherit credentials from environment; align the code or PR description so reviewers know which wording is intended.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| const SIDECAR_HEADER_LABEL: &str = "Choose a type"; | ||
|
|
||
| const NO_SECRET_LABEL: &str = "No API key"; | ||
| const NO_SECRET_LABEL: &str = "Inherit from environment"; |
There was a problem hiding this comment.
💡 [SUGGESTION] The PR description says the intended label is Inherit credentials from environment, but the implementation omits credentials. Align the shipped copy with the documented wording, or update the PR description if the shorter label is intentional.
| const NO_SECRET_LABEL: &str = "Inherit from environment"; | |
| const NO_SECRET_LABEL: &str = "Inherit credentials from environment"; |
There was a problem hiding this comment.
Middleground with the agent... maybe "Inherit key from environment" ?
| const SIDECAR_HEADER_LABEL: &str = "Choose a type"; | ||
|
|
||
| const NO_SECRET_LABEL: &str = "No API key"; | ||
| const NO_SECRET_LABEL: &str = "Inherit from environment"; |
There was a problem hiding this comment.
Middleground with the agent... maybe "Inherit key from environment" ?
2 participants
Summary
Fixes https://linear.app/warpdotdev/issue/APP-4416/consider-renaming-no-api-key-to-something-that-makes-sense
Testing
This PR was created by Oz (running Claude Code).