Skip AgentTips with unresolved keybinding placeholders#9509
Open
MaggieShan wants to merge 4 commits into
Open
Conversation
MaggieShan
force-pushed
the
oz-agent/agent-tips-voice-keybinding-fix
branch
from
4347e79 to
d65e69e
Compare
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR filters AgentTips whose descriptions include unresolved keybinding placeholders and adds singleton revalidation hooks for settings, team, and keybinding changes.
Concerns
- The new revalidation hooks update only the singleton tip model, but the visible agent status bar stores a cloned
current_tip; this can leave an already-rendered keybinding tip visible with a raw<keybinding>placeholder after the binding is cleared.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
MaggieShan
force-pushed
the
oz-agent/agent-tips-voice-keybinding-fix
branch
4 times, most recently
from
f3b109a to
1562345
Compare
When a tip's description contains '<keybinding>' but no keybinding is configured (e.g. voice mode tip with voice_input_toggle_key == None), is_tip_applicable now returns false so the raw '<keybinding>' string is never shown to users. This specifically fixes the voice tip: it is added to the tips pool whenever voice input is enabled, but the keybinding is only set after the user first interacts with voice. Previously the tip could be selected and displayed with the literal text '<keybinding>'. Now it is filtered out at refresh time until a toggle key is configured. The same guard also protects all other keybinding-based tips in case a user has unbound the corresponding action. Co-Authored-By: Oz <oz-agent@warp.dev>
MaggieShan
force-pushed
the
oz-agent/agent-tips-voice-keybinding-fix
branch
from
1562345 to
72f9cb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AgentTip::is_tip_applicablesuch that tips that expect a keybinding but don't have one are removed from the displayed listTesting
Verified locally with only the voice tip - when setting is disabled or when keybinding is not available, the tip is not applicable/not shown
https://www.loom.com/share/dcfcf6a0b8b24be8aea1ca24dd27ddc9
Agent Mode