Codacy Fixes

Author: chughts

services/assistant/v2.js

@@ -54,7 +54,7 @@ module.exports = function(RED) {
         username : sUsername || node.credentials.username,
         password : sPassword || node.credentials.password || config.password,
         apikey : sApikey || node.credentials.apikey || config.apikey,
-      }
+      };
 
       if (msg.params) {
         if (msg.params.username) {
@@ -191,10 +191,11 @@ module.exports = function(RED) {
 
     function setServiceSettings(msg, creds) {
       const serviceSettings = {
-          headers: {
-            'User-Agent': pkg.name + '-' + pkg.version
-          }
+        headers: {
+          'User-Agent': pkg.name + '-' + pkg.version
+        }
       };
+
       let endpoint = '',
         optoutLearning = false,
         version = SERVICE_VERSION;
@@ -254,7 +255,7 @@ module.exports = function(RED) {
 
     function buildService(settings) {
       node.service = new AssistantV2(settings);
-      return Promise.resolve()
+      return Promise.resolve();
     }
 
     function checkSession(params) {
@@ -267,16 +268,14 @@ module.exports = function(RED) {
           }, function(err, response) {
             if (err) {
               reject(err);
-            } else {
-              if (response && response.session_id) {
-                params.session_id = response.session_id;
-                if (!config.multisession) {
-                  node.context().flow.set('session_id', params.session_id);
-                }
-                resolve();
-              } else {
-                reject('Unable to set session');
+            } else if (response && response.session_id) {
+              params.session_id = response.session_id;
+              if (!config.multisession) {
+                node.context().flow.set('session_id', params.session_id);
               }
+              resolve();
+            } else {
+              reject('Unable to set session');
             }
           });
         }

services/discovery/v1.js

@@ -263,6 +263,7 @@ module.exports = function (RED) {
 
   function executeMethod(node, method, params, msg) {
     let discovery = discoveryutils.buildService(username, password, apikey, endpoint);
+    var p = null;
 
     switch (method) {
     case 'createEnvrionment':

services/language_translator/v3-doc.js

@@ -74,8 +74,7 @@ module.exports = function (RED) {
     lt.listModels({}, function (err, models) {
       if (err) {
         res.json(err);
-      }
-      else {
+      } else {
         res.json(models);
       }
     });
@@ -164,7 +163,7 @@ module.exports = function (RED) {
               try {
                 data = JSON.parse(body);
               } catch(e) {
-                data = body
+                data = body;
               }
               resolve(data);
               break;
@@ -260,24 +259,12 @@ module.exports = function (RED) {
       if (msg && msg.filename) {
         name = msg.filename;
       } else if (config && config.filename ) {
-        name = config.filename
+        name = config.filename;
       }
       name = name.replace(/[^0-9a-z]/gi, '');
       return (name + suffix);
     }
 
-    function docID(msg) {
-      if (msg.payload && 'string' === typeof msg.payload) {
-        return msg.payload;
-      } else if (msg.payload &&
-                   'object' === typeof msg.payload &&
-                   msg.payload.document_id) {
-        return msg.payload.document_id;
-      } else {
-        return config['document-id'];
-      }
-    }
-
     function sourceLang(msg) {
       if (msg.payload &&
             'object' === typeof msg.payload &&
@@ -288,6 +275,18 @@ module.exports = function (RED) {
       return msg.srclang ? msg.srclang : config.srclang;
     }
 
+    function docID(msg) {
+      if (msg.payload && 'string' === typeof msg.payload) {
+        return msg.payload;
+      }
+      if (msg.payload &&
+            'object' === typeof msg.payload &&
+               msg.payload.document_id) {
+        return msg.payload.document_id;
+      }
+      return config['document-id'];
+    }
+
     function executePostRequest(uriAddress, params, msg) {
       return new Promise(function resolver(resolve, reject){
         var authSettings = buildAuthSettings();
@@ -298,7 +297,7 @@ module.exports = function (RED) {
           auth: authSettings,
           formData: params
         }, (error, response, body) => {
-          if (!error && response.statusCode == 200) {
+          if (!error && response.statusCode === 200) {
             let data = JSON.parse(body);
             resolve(data);
           } else if (error) {
@@ -407,7 +406,7 @@ module.exports = function (RED) {
         'documentStatus' : executeGetDocumentStatus,
         'deleteDocument' : executeDeleteDocument,
         'getDocument' : executeGetDocument
-      }
+      };
 
       f = execute[action] || executeUnknownMethod;
       node.status({ fill: 'blue', shape: 'dot', text: 'processing' });

services/natural_language_understanding/v1.js

@@ -83,7 +83,7 @@ module.exports = function (RED) {
     var limitCharacters = parseInt(config.limittextcharacters);
 
     if (! isNaN(limitCharacters) && 0 < limitCharacters) {
-      options.limit_text_characters = limitCharacters
+      options.limit_text_characters = limitCharacters;
     }
 
     return Promise.resolve();

services/personality_insights/v3.js

@@ -51,7 +51,7 @@ module.exports = function (RED) {
     if (!msg.payload) {
       return Promise.reject('Missing property: msg.payload');
     }
-    if ('string' !== typeof msg.payload  &&
+    if ('string' !== typeof msg.payload &&
            'object' !== typeof msg.payload) {
       return Promise.reject('submitted msg.payload is not text or json object');
     }

utilities/payload-utils.js

@@ -157,14 +157,12 @@ PayloadUtils.prototype = {
   // Function that is returns a function to count
   // the characters in each language.
   word_count: function(ct) {
-    var count = require('word-count') ;
+    var count = require('word-count'),
       fn = function(txt, cb) {
         // default
         return cb(txt.split(' ').length);
-      },
-      dic_path = '/../../kuromoji/dict',
-      dic_dir = path.normalize(__dirname + dic_path),
-      tokenizer = null;
+      };
+      
     if (ct === 'ja') {
       fn = function(txt, cb) {
         cb(200);