Skip to content

fix(hygiene): map-fields GraphQL $p-unused error (arming blocker) - #19

Merged
yakimoto merged 1 commit into
mainfrom
fix-map-fields-query
Jul 24, 2026
Merged

fix(hygiene): map-fields GraphQL $p-unused error (arming blocker)#19
yakimoto merged 1 commit into
mainfrom
fix-map-fields-query

Conversation

@yakimoto

@yakimoto yakimoto commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Smoke test (wave-av/.github#18, a form-shaped issue) failed the map-fields job with:
Variable $p is declared by anonymous query but not used.

The item-resolution query declared query($n:ID!,$p:ID!) but only used $p inside the client-side jq filter (select(.project.id==...)), never in the GraphQL body — GraphQL rejects unused declared variables. Fix: drop $p from the declaration and the -F p= arg; the project filter stays in jq via the PROJECT_ID shell var (the fields query and the sweep query were already correct).

After merge I'll re-run the smoke to confirm map-fields stamps Area/Priority, then delete the smoke issue.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Note

Low Risk
Single-line GraphQL/shell fix in CI with no runtime or security impact; project filtering logic is unchanged.

Overview
Fixes the map-fields job in ticket-hygiene.yml, which was failing with GraphQL error "Variable $p is declared but not used".

The project-item lookup query declared $p but only filtered by project ID in jq (select(.project.id=="$PROJECT_ID")), not in the GraphQL document. The fix drops $p from the query signature and removes the unused -F p="$PROJECT_ID" argument; behavior is unchanged because board scoping still happens in the shell/jq step.

Reviewed by Cursor Bugbot for commit 2e33fcf. Configure here.


Summary by cubic

Fix the ticket-hygiene map-fields step by removing an unused GraphQL variable that caused "Variable $p is declared but not used" errors. Dropped $p from the query and the -F p= flag; project filtering remains in jq using PROJECT_ID, unblocking the job.

Written for commit 2e33fcf. Summary will update on new commits.

Review in cubic

GraphQL rejected the projectItems query with "Variable \$p is declared but
not used" — \$p was only referenced in the client-side jq filter, not the
query body. Removing it fixes the map-fields job (smoke issue #18 failed on
this). The project filter stays in jq via the PROJECT_ID shell var.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2e33fcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cursor

cursor Bot commented Jul 24, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_15a0e788-dafc-4ffb-81cb-cd748c8bc7f4)

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ecc4285f-766b-441d-94ba-3cc041a6f8b9

📥 Commits

Reviewing files that changed from the base of the PR and between d396f7b and 2e33fcf.

📒 Files selected for processing (1)
  • .github/workflows/ticket-hygiene.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-map-fields-query
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix-map-fields-query

Comment @coderabbitai help to get the list of available commands.

@yakimoto
yakimoto merged commit 14010fb into main Jul 24, 2026
11 checks passed
@yakimoto
yakimoto deleted the fix-map-fields-query branch July 24, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant