Add intermediate certificates to auth token model#123
Open
aarmam wants to merge 14 commits into
Open
Conversation
aarmam
force-pushed
the
NFC-128
branch
4 times, most recently
from
July 1, 2026 06:50
b78e560 to
0a16568
Compare
aarmam
marked this pull request as draft
July 2, 2026 10:44
aarmam
force-pushed
the
NFC-128
branch
10 times, most recently
from
July 6, 2026 09:27
0cd5c01 to
79d06f7
Compare
aarmam
marked this pull request as ready for review
July 6, 2026 09:34
aarmam
force-pushed
the
NFC-128
branch
2 times, most recently
from
July 14, 2026 15:40
9454b1a to
52d4a67
Compare
Once intermediate certificates can sit between the leaf and the trust anchor, the OCSP CertificateID must be built from the certificate that directly issued the subject, and RFC 6960 responder authorization must reference the same certificate. Return the direct issuer from the built certification path; when the path has a single certificate, the trust anchor is the direct issuer. Behavior is unchanged for configurations where every configured CA is a trust anchor.
…-path validation The shared certification-path validation labeled every leaf validity failure as a user-certificate failure, so the AIA OCSP responder flow had to duplicate the validity check beforehand to get a correctly attributed message. Let callers name the certificate role and drop the duplicate responder pre-check; validity is still checked first, inside the shared method.
…rtificates Web eID 1.1 tokens may carry the intermediate CA certificates of the certificate chain. Accept them in certification-path validation as untrusted path candidates only: the path must still terminate at a configured trust anchor. No caller passes token data yet.
…rtificates Token-supplied intermediates are attacker-controlled input, so a revoked intermediate must not become part of a trusted certification path. Check the CA suffix of the built path (the leaf's role-specific revocation policy stays with the caller) with the platform JCA PKIXRevocationChecker, which prefers OCSP and falls back to CRLs; SOFT_FAIL is deliberately not enabled. Revocation checking is an explicit caller choice: the authentication and signing certificate paths enable it, the AIA OCSP responder path does not, per RFC 6960 section 4.2.2.2.1 id-pkix-ocsp-nocheck semantics and because checking the responder's own chain via OCSP would be circular. The platform checker is used instead of the application OcspClient because intermediate CAs commonly publish CRLs without OCSP AIA records, the OcspClient freshness policy (nonce, time skew, thisUpdate age) encodes end-entity assumptions that are wrong for CA-tier data, and the WE2-1030 platform-OCSP refactor removes the OcspClient from core validation, so platform-based checking ports forward as a block. A revocation failure names the offending intermediate certificate instead of the validated leaf.
…d responder certificates
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mart Aarma mart.aarma@nortal.com