Remove calls to deprecated CRM_Utils_Array::value#84
Open
colemanw wants to merge 1 commit into
Open
Conversation
colemanw
force-pushed
the
noUtilsArrayValue
branch
from
a33fb9f to
e2d4603
Compare
🤖 WA Code Reviewer ResultPR OverviewThis PR is a refactor 🛠️ Replaces deprecated function with equivalent null-coalescing operator. Behavior should be the same before/after. Change Details
|
| Major Changes | Description |
|---|---|
| SimpleDonationSetting.php | This diff contains changes to three functions: setDefaultValues, postProcess, and transactDonation. The changes primarily involve replacing CRM_Utils_Array::value with the null coalescing operator ?? NULL to handle cases where the value may not exist. Additionally, the changes to transactDonation also include replacing $_POST with its individual values (params, amount, creditInfo, and isTest) to handle cases where the values may not exist. |
PR Quality Assessment:
Good code quality. The PR meets most standards but has some areas for improvement.
===================== Report End =====================
Replaces deprecated function with equivalent null-coalescing operator. Behavior should be the same before/after.
colemanw
force-pushed
the
noUtilsArrayValue
branch
from
e2d4603 to
10b727c
Compare
🤖 WA Code Reviewer ResultPR OverviewThis PR is fixing bug 🐛 Replaces deprecated function with equivalent null-coalescing operator. Behavior should be the same before/after. Change Details
|
| Major Changes | Description |
|---|---|
| SimpleDonationSetting.php | Here is a brief summary of the diff content: This diff contains changes to the CRM/SimpleDonate/Form/SimpleDonationSetting.php file. It updates several instances of using CRM_Utils_Array::value() to instead use the null coalescing operator ?? to handle null or undefined values. |
PR Quality Assessment:
Good code quality. The PR meets most standards but has some areas for improvement.
===================== Report End =====================
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces deprecated function with equivalent null-coalescing operator. Behavior should be the same before/after.