Conversation
…resToTrack, Harris, Shi-Tomasi, preCornerDetect) Agent-Logs-Url: https://github.com/webarkit/purecv/sessions/3be57b21-2870-4ea6-9b9e-09a0d8c480d8 Co-authored-by: kalwalt <1275858+kalwalt@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
kalwalt
April 9, 2026 19:19
View session
… morph/pyramid tests) Co-authored-by: kalwalt <1275858+kalwalt@users.noreply.github.com>
Agent-Logs-Url: https://github.com/webarkit/purecv/sessions/838d152f-65d8-4d96-8b46-8a8b888160a1 Co-authored-by: kalwalt <1275858+kalwalt@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was implemented
New module:
src/imgproc/feature.rsSix new corner detection functions (all OpenCV-compatible, single-channel
Matrix<T>, returningResult<…>):corner_harrisdet(M) − k·tr(M)²corner_min_eigen_valcorner_eigen_vals_and_vecsgood_features_to_trackcorner_sub_pixpre_corner_detectAll functions support the
parallelandsimdfeature flags and useBorderTypesfor border extrapolation.New example:
examples/corner_detection.rsSingle file that groups all six corner detectors against a real image (defaults to
butterfly.jpg, accepts any image via CLI):Steps demonstrated:
good_features_to_track— Shi-Tomasi mode, top 200 cornersgood_features_to_track— Harris mode, top 200 cornerscorner_sub_pix— sub-pixel refinement with before/after Δ printedpre_corner_detect— feature map saved as PNGcorner_eigen_vals_and_vecs— λ1 channel extracted and savedModule wiring
src/imgproc.rs—pub use feature::*;addedsrc/lib.rs—TermCriteria,TermType,Point2f,Size2iadded to preludeTests
224 comprehensive unit tests added across
src/imgproc/tests.rs:corner_sub_pixChecklist
src/imgproc/feature.rs— all six corner detection functionsexamples/corner_detection.rs— unified example for all detectorssrc/imgproc.rs/src/lib.rs— public API wired upsrc/imgproc/tests.rs— 224 tests passcargo fmt && cargo clippy— zero warningscargo run --example corner_detection— verified onbutterfly.jpgcargo test— all tests passCloses #24