Skip to content
This repository was archived by the owner on Aug 8, 2022. It is now read-only.

Add TYPO3 8 compatible FlashMessage Rendering in update script#501

Open
ipf wants to merge 1 commit into
webdevops:masterfrom
ipf:flashmessages
Open

Add TYPO3 8 compatible FlashMessage Rendering in update script#501
ipf wants to merge 1 commit into
webdevops:masterfrom
ipf:flashmessages

Conversation

@ipf

@ipf ipf commented Sep 1, 2017

Copy link
Copy Markdown
Member

This fixes the issue, that executing the updater script in the TYPO3 8
backend results in a fatal error, because the FlashMessage handling has
been changed.

This fixes the issue, that executing the updater script in the TYPO3 8
backend results in a fatal error, because the FlashMessage handling has
been changed.
@thomaszbz

Copy link
Copy Markdown
Member

thanks a lot

@thomaszbz thomaszbz added this to the 3.0.1 milestone Sep 1, 2017
@thomaszbz

Copy link
Copy Markdown
Member

@ipf which version were you coming from? 1.0.x?

@ipf

ipf commented Sep 1, 2017

Copy link
Copy Markdown
Member Author

Just installed it in 3.0.0 and tried to run the updater script that failed. So not really coming from a version, but a clean install and was curious what happened when I push the button in the EM.

@thomaszbz

thomaszbz commented Sep 1, 2017

Copy link
Copy Markdown
Member

@ipf Funny. We've seen more than 800 downloads of 3.0.0 now (together with Packagist), and you're reporting the first bug which is 3.0.0 specifc.

Thanks for catching this!

@thomaszbz

thomaszbz commented Sep 1, 2017

Copy link
Copy Markdown
Member

@ipf Please post your exact TYPO3 version and PHP version in #502.

If you find a documented breaking change somewhere, that would be of help, too.

@thomaszbz thomaszbz removed this from the 3.0.1 milestone Sep 1, 2017
@nostadt

nostadt commented Oct 23, 2017

Copy link
Copy Markdown

Hmm, is there a plan to merge this pr?

@thomaszbz

thomaszbz commented Oct 23, 2017

Copy link
Copy Markdown
Member

@AMartinNo1 It will be part of the next release. For metaseo 3.0.0 nobody needs to execute the update script: Fresh installs don't need to update the schema. And upgraders also don't have to run it as long as they come from 2.1.0 (and even back to 2.0.0). Should not be urgent, or is it?

Eventually, the schema update even runs, just the flash message fails.

@nostadt

nostadt commented Oct 23, 2017

Copy link
Copy Markdown

I see. Alright, I was just curious as the milestone is set to 1st Sep. 2017 and we experience some issues. The update script was one possible solution - it did not fix our main issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants