Use copyBufferToBuffer overload#500
Merged
beaufortfrancois merged 2 commits intoJul 3, 2025
Merged
Conversation
769de44 to
e6e41b7
Compare
Collaborator
Then I'll mark it as "draft" for now. |
kainino0x
approved these changes
Apr 1, 2025
Collaborator
Author
|
FYI copyBufferToBuffer overload is now available in Chrome 137 37.0.7122.0 |
Collaborator
Author
|
FYI @mwyrzykowski |
Collaborator
Author
|
FYI Safari Tech Preview and Firefox Nightly still don't support yet this copyBufferToBuffer overload. |
Contributor
|
Filed https://bugs.webkit.org/show_bug.cgi?id=293905 for WebKit |
Collaborator
Author
Thanks for WebKit/WebKit#46220! |
…erToBufferOverload
Collaborator
Author
|
This PR now works fine with Chrome, Firefox Nightly, and Safari Tech Preview. I believe we can merge it. |
mwyrzykowski
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses copyBufferToBuffer overload following gpuweb/gpuweb#5098. Note that it should be merged only when browsers have started implementing it.
FYI It is currently gated behind the WebGPUExperimentalFeatures blink runtime feature in Chromium. See https://chromium-review.googlesource.com/c/chromium/src/+/6401714