Fall back when particles HDR canvas format is unsupported#567
Open
lyonsno wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #564.
The particles sample currently configures its canvas as
rgba16floatunconditionally. Firefox reports that format as unsupported and throws fromGPUCanvasContext.configure(), which sends the page through the global "uncaught exception, please report a bug" dialog.This keeps
rgba16floatas the preferred HDR path, but catches unsupported canvas configuration and falls back to the browser's preferred canvas format. When the fallback path is active, the sample omits HDR-onlytoneMappingsettings and marks the HDR settings UI as browser-unsupported instead of stopping the page.Changes
rgba16floatcanvas configuration before creating the render pipeline.toneMappingsettings while using the fallback format.Verification
npx eslint sample/particles/main.ts sample/util.tsnpm run lintnpm run buildgit diff --checkrgba16float, logged a fallback tobgra8unorm, continued rendering the particles sample, and thebrightnessFactorcontrol remained interactive without an uncaught-exception dialog.