Add detailed app listing and type filtering support#7
Merged
Conversation
Align the `--list` output with webos-tools/cli by hiding non-visible apps, and add the `--listfull`/`-F` and `--type`/`-t` options: - Filter out apps whose `visible` flag is not set, mirroring the reference CLI's non-signage listing behavior. - `--listfull` dumps full app metadata via a port of the reference `convertJsonToList` renderer; remaining fields are captured with a flattened `extra` map so nothing is dropped. - `--type` filters the listed apps by app type. https://claude.ai/code/session_017vAGzSSYNcgdQzJRLWfX47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the
listcommand to support detailed app information display and filtering by app type, matching the reference CLI's behavior.Key Changes
New CLI flags:
--listfull/-F: Display detailed information for each app instead of just IDs--type/-t: Filter listed apps by app typeApp struct enhancements:
Serializederive to support JSON conversion for detailed outputvisiblefield to filter out non-visible apps (matching reference CLI behavior)extrafield with#[serde(flatten)]to capture and preserve additional app properties for full listingList output formatting:
convert_json_to_list()function to render JSON as indented text with hierarchical-prefixesImplementation details:
ListApps::list_apps()trait method signature to acceptlist_fullandtype_filterparametersis_nested()andscalar_to_string()to handle JSON-to-text conversion logicconvertJsonToListbehavior for consistent output formattinghttps://claude.ai/code/session_017vAGzSSYNcgdQzJRLWfX47