Skip to content

hal-gal: fix EGL_BAD_ACCESS after first frame by moving capture off init thread #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sundermann merged 1 commit into from
Jul 4, 2026
Merged

hal-gal: fix EGL_BAD_ACCESS after first frame by moving capture off init thread #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions unicapture/backends/libhalgal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,14 @@ int capture_init(cap_backend_config_t* config, void** state_p)
}
INFO("HAL_GAL_CreateSurface done! SurfaceID: %d", this->surface_info.vendorData);

if ((ret = HAL_GAL_CaptureFrameBuffer(&this->surface_info)) != 0) {

ERR("HAL_GAL_CaptureFrameBuffer failed: %x", ret);
ret = -3;
goto err_destroy;
}
INFO("HAL_GAL_CaptureFrameBuffer done! %x", ret);
// NOTE: We deliberately do NOT call HAL_GAL_CaptureFrameBuffer() here.
// capture_init() runs on the caller's/setup thread, but actual frame
// capture happens later on unicapture's dedicated capture thread
// (see unicapture_run() -> capture_acquire_frame()). HAL_GAL_Init()
// appears to bind an EGL/GL context to the calling thread, and that
// binding is thread-affine. Capturing a frame here would bind/use the
// context on this (wrong) thread, causing EGL_BAD_ACCESS (0x3002) on
// every subsequent capture attempt from the real capture thread.

// ToDo: compare open("/dev/mem", O_RDWR|O_SYNC);
if ((this->mem_fd = open("/dev/gfx", 2)) < 0) {
Expand Down
Loading