chore: design tweaks#38
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ae4c20a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors several Teamwork TUI pages and shared components to standardize layout using new Card and ListItem primitives, and updates the command palette UI to display options grouped by category.
Changes:
- Replaced older bordered/section layouts with
Card+ListItemacross Teamwork tabs (Project/Timers/My Work). - Reworked timer UI from a status indicator to a compact elapsed-time badge (
TimerBadge). - Updated
DialogSelectrendering to group options by category (with headings) and adjusted command categories.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tui/pages/teamwork/timers-tab.tsx | Uses Card/ListItem and switches timer display to TimerBadge + inline duration metadata. |
| src/tui/pages/teamwork/project-tab.tsx | Converts project/pinned task list UI to Card and updates TaskList props for timer badge support. |
| src/tui/pages/teamwork/my-work-tab.tsx | Replaces Section placeholder with a Card placeholder. |
| src/tui/components/teamwork/timer-indicator.tsx | Replaces the old indicator with TimerBadge and duration formatting logic. |
| src/tui/components/teamwork/task-list.tsx | Renders tasks as ListItems and shows per-task TimerBadge when timers exist. |
| src/tui/components/layout/section.tsx | Removes the old Section layout component. |
| src/tui/components/layout/list-item.tsx | Adds new compact selectable list item component. |
| src/tui/components/layout/card.tsx | Adds new titled card grouping component. |
| src/tui/components/layout/accordion-section.tsx | Adjusts accordion styling to match new card-like rounded border design. |
| src/tui/components/dialog-select.tsx | Adds grouped rendering by category headings (and updates layout spacing). |
| src/tui/app.tsx | Updates command palette categories to align with new grouping headings. |
| .changeset/bumpy-donkeys-watch.md | Adds a patch changeset describing these design tweaks. |
Comments suppressed due to low confidence (1)
src/tui/components/dialog-select.tsx:95
- The list is rendered in grouped/section order (
sections()+startIndex), but keyboard navigation andsubmit()still use the originalfiltered()order. That can cause the highlighted option (rendered order) to differ from the option that gets submitted, and Up/Down navigation won't follow the visual order. Consider driving selection/submit from the same flattened grouped list used for rendering.
const move = (direction: 1 | -1) => {
if (filtered().length === 0) return;
setSelectedIndex((index) => {
const next = index + direction;
if (next < 0) return filtered().length - 1;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marlon U. Marcello <marlon.marcello@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marlon U. Marcello <marlon.marcello@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marlon U. Marcello <marlon.marcello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Just some small design tweaks to clean up the work so far.
Type of Change
Local Verification
bun run fmtbun run lintbun run checkbun testbun run buildRelease Impact
.changeset/