Add process model processing for the "Priority" header.#1757
Open
pmeenan wants to merge 1 commit intowhatwg:mainfrom
Open
Add process model processing for the "Priority" header.#1757pmeenan wants to merge 1 commit intowhatwg:mainfrom
pmeenan wants to merge 1 commit intowhatwg:mainfrom
Conversation
Contributor
Author
|
Tests and implementation bugs coming soon. |
annevk
approved these changes
Jun 13, 2024
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Thanks, this looks reasonable to me modulo nits. This means that service workers do not get to see the header ever unless it was set by a web developer. Do we have test coverage for that as well?
| <a>HTTP header layer division</a> for more details. | ||
|
|
||
| <li><p>If <var>httpRequest</var>'s <a for=request>header list</a> | ||
| <a for="header list">does not contain</a> `<code>Priority</code>`, then user agents may |
Member
There was a problem hiding this comment.
This and below should not be indented extra. Please align with <li><p>.
| <a for="header list">does not contain</a> `<code>Priority</code>`, then user agents may | ||
| <a for="header list">append</a> a `<code>Priority</code>` <a>header</a> with an | ||
| <a>implementation-defined</a> value derived from <var>httpRequest</var>'s | ||
| <a for=request>internal priority</a> in accordance with RFC 9218. [[!RFC9218]] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priorityrequest header #1718(See WHATWG Working Mode: Changes for more details.)
This adds the processing for the
PriorityHTTP header from HTTP Extensible Priorities (RFC 9218).The actual priority values are implementation-specific but this change makes it clear that an existing value should not be overwritten if the header is already present.
Fix #1718
Preview | Diff