Skip to content

Miscellaneous Fixes#619

Merged
KernelGhost merged 38 commits into
winapps-org:mainfrom
KernelGhost:main
Aug 2, 2025
Merged

Miscellaneous Fixes#619
KernelGhost merged 38 commits into
winapps-org:mainfrom
KernelGhost:main

Conversation

@KernelGhost

Copy link
Copy Markdown
Member

OpenAI's 'Codex' found various typos and one minor issue with variable quoting.

@oskardotglobal oskardotglobal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because the patches from the Nix package no longer apply, we need to address that before merging. Otherwise, this looks good.

@oskardotglobal

Copy link
Copy Markdown
Member

Also, I got prompted to install https://github.com/apps/chatgpt-connector on the org. Is that so codex can access PRs like Copilot does?

I'd be willing to add it right away if it's only manual access but if this does like auto-reviews or something we should consult some more people for opinions

@KernelGhost

Copy link
Copy Markdown
Member Author

@oskardotglobal Was trying out Codex for the first time today and was exploring some of the integration features. I think it’s probably safest to decline the request for now. Better to keep things restricted to my own fork in case it does something unexpected upstream. Cheers.

KernelGhost and others added 3 commits August 1, 2025 17:10
Comment thread oem/install.bat Outdated
@KernelGhost

Copy link
Copy Markdown
Member Author
image

Commit e803794 improves install.bat by adding console output to aid debugging and removing a redundant task deletion step (unnecessary as the /f flag used during task creation already forces overwriting of existing tasks with the same name). Changes have been thoroughly tested in a Windows VM.

@oskardotglobal

Copy link
Copy Markdown
Member

Nice. I actually replaced install.bat with a powershell script in #308, but this would be nice for non-docker setups

@oskardotglobal oskardotglobal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Garnix says it's building so your patch seems to work.

@KernelGhost KernelGhost merged commit b5cb322 into winapps-org:main Aug 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants