Skip to content

Add option to start minimized#146

Closed
ConorIA wants to merge 10 commits into
wireapp:masterfrom
ConorIA:startMini
Closed

Add option to start minimized#146
ConorIA wants to merge 10 commits into
wireapp:masterfrom
ConorIA:startMini

Conversation

@ConorIA

@ConorIA ConorIA commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

Adds a checkbox to the 'Window' menu to start the app in the tray (i.e. skip main.show() on startup.)
This partially addresses #104.

I'm not sure what is going on in the Windows menu, so I didn't touch that, but I feel pretty confident about the code for macOS. Tried, tested and true on Linux, of course!

@shvchk

shvchk commented Nov 4, 2016

Copy link
Copy Markdown

Would be nice to also have this as an argument, like --minimized, so that Wire could be added to autostart to be launched minimized, and showed as usual if launched manually.

For now I'm using this script in autostart (on Linux) to start Wire minimized.

@ConorIA

ConorIA commented Nov 4, 2016

Copy link
Copy Markdown
Contributor Author

I'm not entirely sure what the --startup flag is for, but if it is true, I think the app window won't show. It is on the same line as the change I made in this PR. @lipis, is this used anywhere else in the app?

@ConorIA

ConorIA commented Nov 4, 2016

Copy link
Copy Markdown
Contributor Author

Come to think of it, my guess is that that flag is precisely for when you want Wire to launch on startup. 😌

@shvchk

shvchk commented Nov 4, 2016

Copy link
Copy Markdown

Ha! There really is if (!argv.startup) check before main.show(), thanks for the tip!

P.S. Then maybe it would be more clear to have both option and argument checked at once, like if (!argv.startup && !startInTray) instead of the second if (!startInTray) check?

@ConorIA

ConorIA commented Nov 5, 2016

Copy link
Copy Markdown
Contributor Author

Thanks for the suggestion. It's addressed in the last couple of commits.

@ConorIA

ConorIA commented Dec 19, 2016

Copy link
Copy Markdown
Contributor Author

Updated to include newer changes.

@ConorIA ConorIA mentioned this pull request Dec 20, 2016
@lipis

lipis commented Jan 19, 2017

Copy link
Copy Markdown
Contributor

Handled in #329

@lipis lipis closed this Jan 19, 2017
@ConorIA ConorIA deleted the startMini branch January 19, 2017 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants