use fast path in blendSegment to bump up FPS#5464
Open
Conversation
Contributor
WalkthroughThis PR optimizes the segment blending pipeline by introducing a fast-path in Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
just FYI: ported this improvement over to my WLEDbus driver branch, I do get ~100FPS for the 2 overlapping segments which come in at 84.5FPS using NPB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently blendSegment is "the bottleneck" in the rendering pipeline. I ran a breakdown of times (in µs):
this is for a single segment. blending is slow for a "just copy the segment buffer"
with this PR it becomes:
Improvements in FPS:
i.e. up to 10% faster.
test run on C3, 2 outputs 256 pixels each, 32x16 matrix using PS-Fire
Summary by CodeRabbit