Restore executable bit on edited scripts#15
Merged
Conversation
The dead-code removal edits rewrote these files through a temp file, which dropped their executable bit (755 -> 644). Restore the original mode. No content change. lib modules are sourced so this is cosmetic, but keeps the permissions consistent with the rest of the tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the dead-code cleanup PRs (#12, #13, #14). Those edits rewrote several files through a temp file (
sed ... > tmp && mv tmp file), which silently dropped the executable bit (755 → 644) on files that were originally executable.This restores the original mode on the five affected files:
install.shlib/core.shlib/crypto.shlib/generators.shlib/schedule.shDetails
lib/*.shmodules are sourced, not executed, andinstall.shis run viacurl … | bash. But the inconsistency with the rest of the tree (e.g.backup.sh,verify.sh,setup.share 755) is unintended, so this puts them back.history.sh,jobs.sh,migration.sh,restic.sh) are left as-is.Testing
No code change.
git diffshows onlymode change 100644 => 100755for the five files.