Remove current_request_steps in Req.Request

[thenrio]

Just use request_steps.

[wojtekmach]

Thank you for the PR. It seems we are missing tests because the build should have failed as we needed this design for things like not replying base_url+url on retries, etc. I’ll investigate. Maybe it is not needed after all!

[thenrio]

Sure! Cheers.

[wojtekmach]

Note to self: revisit Req.Request.prepare/1 while at it.

[thenrio]

Hi @wojtekmach, I noticed that Req.Request.run_request/1 "consumes" the current_request_steps:

req/lib/req/request.ex

Line 979 in 7616d39

run_request(%{request | current_request_steps: rest})

.

Then we don't run base_url or params twice on retry, such as in

req/test/req/steps_test.exs

Line 1587 in 7616d39

test "does not re-encode params", c do

.
In fact, retry does not run any of the input request_steps, as current_request_steps is empty...

This commit "consumes" the request_steps, so we don't run base_url or params twice on retry.
We achieve same behavior with a list removed from memory and a lookup removed,

req/lib/req/request.ex

Line 975 in 7616d39

step = Keyword.fetch!(request.request_steps, step)

.

Cheers.

[wojtekmach]

Sorry for delay, this is tricky because the whole reason we introduced :current_request_steps was to avoid this:

Req.new(params: [a: 1])
|> Req.Request.prepend_response_steps(
  # as if we don't have current_request_steps
  test: fn {req, resp} ->
    req = put_in(req.current_request_steps, Keyword.keys(req.request_steps))
    {req, resp}
  end
)
|> Req.get!(
  retry_delay: 10,
  plug: fn conn ->
    dbg(conn.query_string)
    # conn.query_string #=> "a=1"
    # conn.query_string #=> "a=1&a=1"
    # conn.query_string #=> "a=1&a=1&a=1"
    # conn.query_string #=> "a=1&a=1&a=1&a=1"
    Plug.Conn.send_resp(conn, 500, "")
  end
)

(#140)

But yes, on the flip side it causes #296.

I haven't made up my mind yet which way to go, apologies for the delay.

[wojtekmach]

Another data point: https://github.com/reisub/http_cookie/pull/3/files#diff-afcb5ad934b330c8e7ff684f4861d7a95409c5440099af7c8e47919b210f60c0R65.

[wojtekmach]

Another one: open-telemetry/opentelemetry-erlang-contrib#664